web UI added and refactoring done

python_app/tests/test_laser_control_protocol.py

@@ -17,7 +17,9 @@ DEVICE_MAIN_CHANGE_CURRENT_LD1_HEX = (
     "7777ff3701003d2acc2c10008813ffa5cc2c18ab0a00000a8000000a8000b600"
 )
 DEVICE_MAIN_CHANGE_CURRENT_LD2_HEX = (
-    "7777ff3702003d2acc2c0500881318ab3d2affa50a00000a8000000a80005106"
+    # Word 5 (step) = current_ma_to_n(0.05)=0x0010, matching LD1 and min/max — see the
+    # step-encoding fix in protocol.py (was the inconsistent int(step*100)=0x0005).
+    "7777ff3702003d2acc2c1000881318ab3d2affa50a00000a8000000a80004406"
 )
 
 
@@ -128,6 +130,18 @@ class LaserControlProtocolCompatibilityTest(unittest.TestCase):
         self.assertEqual(ld1_command.hex(), DEVICE_MAIN_CHANGE_CURRENT_LD1_HEX)
         self.assertEqual(ld2_command.hex(), DEVICE_MAIN_CHANGE_CURRENT_LD2_HEX)
 
+    def test_ld1_and_ld2_encode_current_step_identically(self) -> None:
+        # Regression guard for the LD2 step-scale bug: both current-variation channels
+        # must encode the step with the same scale (current_ma_to_n), like min/max.
+        params = dict(static_temp1=28.0, static_temp2=28.9, static_current1=33.0, static_current2=35.0,
+                      min_value=33.0, max_value=35.0, step=0.05, time_step=50, delay_time=10,
+                      message_id=DEVICE_MAIN_MESSAGE_ID, pi_coeff1_p=2560, pi_coeff1_i=128,
+                      pi_coeff2_p=2560, pi_coeff2_i=128)
+        ld1 = Protocol.encode_task_enable(task_type=TaskType.CHANGE_CURRENT_LD1, **params)
+        ld2 = Protocol.encode_task_enable(task_type=TaskType.CHANGE_CURRENT_LD2, **params)
+        # Word 5 (step) is at bytes 10:12 in both frames (sync, header, task, min, max, step).
+        self.assertEqual(ld1[10:12], ld2[10:12])
+
     def test_start_sequence_matches_device_main_order(self) -> None:
         fake_protocol = _FakeProtocol()
         controller = LaserController(pi_coeff1_p=2560, pi_coeff1_i=128, pi_coeff2_p=2560, pi_coeff2_i=128)
@@ -235,6 +249,37 @@ class LaserControlProtocolCompatibilityTest(unittest.TestCase):
                 "message_id": DEVICE_MAIN_MESSAGE_ID,
             },
         )
+        # The variation handoff itself (type + params), not just call order, must be right.
+        variation_payload = controller.calls[3][1]
+        self.assertEqual(variation_payload["variation_type"], VariationType.CHANGE_CURRENT_LD1)
+        self.assertEqual(variation_payload["params"]["step"], 0.05)
+        self.assertEqual(variation_payload["params"]["min_value"], 33.0)
+        self.assertEqual(variation_payload["params"]["max_value"], 35.0)
+
+    def test_apply_radar_manual_mode_sets_manual_without_variation(self) -> None:
+        config = self._kamil_config(
+            {
+                "enabled": True,
+                "port": "/dev/ttyUSB0",
+                "mode": "manual",
+                "manual": {"temp1": 26.0, "temp2": 27.0, "current1": 30.0, "current2": 31.0},
+            }
+        )
+        with patch("python_app.hardware_full.laser_control.controller.LaserController", _FakeLaserController):
+            applied = apply_kamil_adc_laser_control(config)
+        self.assertTrue(applied)
+        controller = _FakeLaserController.instances[0]
+        self.assertEqual([name for name, _ in controller.calls], ["connect", "reset", "set_manual_mode", "disconnect"])
+        self.assertEqual(controller.calls[2][1]["current1"], 30.0)
+
+    def test_apply_radar_unknown_variation_type_raises(self) -> None:
+        config = self._kamil_config(
+            {"enabled": True, "port": "/dev/ttyUSB0", "mode": "variation",
+             "variation": {"variation_type": "NOT_A_REAL_TYPE"}}
+        )
+        with patch("python_app.hardware_full.laser_control.controller.LaserController", _FakeLaserController):
+            with self.assertRaisesRegex(ValueError, "variation_type"):
+                apply_kamil_adc_laser_control(config)
 
     def test_apply_radar_skips_disabled_laser_control(self) -> None:
         config = self._kamil_config({"enabled": False})