improved logging
This commit is contained in:
@@ -4,11 +4,14 @@ from __future__ import annotations
|
||||
|
||||
from dataclasses import dataclass
|
||||
import json
|
||||
import logging
|
||||
from pathlib import Path
|
||||
|
||||
from python_app.models.run_config_model import RunConfigModel
|
||||
from python_app.storage.npz_store import radar_key_from_config
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
_RADAR_SWEEP_KEYS = (
|
||||
"start_hz",
|
||||
"stop_hz",
|
||||
@@ -59,6 +62,7 @@ def scan_radar_config_variants(
|
||||
|
||||
directory = Path(normalized_path).expanduser()
|
||||
if not directory.exists():
|
||||
logger.warning("Radar config variant directory does not exist: %s", directory)
|
||||
return [], RadarConfigScanSummary(
|
||||
directory_path=str(directory),
|
||||
json_file_count=0,
|
||||
@@ -68,6 +72,7 @@ def scan_radar_config_variants(
|
||||
issues=(f"Directory does not exist: {directory}",),
|
||||
)
|
||||
if not directory.is_dir():
|
||||
logger.warning("Radar config variant path is not a directory: %s", directory)
|
||||
return [], RadarConfigScanSummary(
|
||||
directory_path=str(directory),
|
||||
json_file_count=0,
|
||||
@@ -88,16 +93,30 @@ def scan_radar_config_variants(
|
||||
variant = _load_radar_config_variant(path, base_config=base_config)
|
||||
except Exception as exc: # noqa: BLE001
|
||||
issues.append(f"{path.name}: {type(exc).__name__}: {exc}")
|
||||
logger.warning("Skipping radar config variant %s: %s: %s", path.name, type(exc).__name__, exc)
|
||||
continue
|
||||
if variant.radar_key in seen_radar_keys:
|
||||
duplicate_variant_count += 1
|
||||
issues.append(
|
||||
f"{path.name}: duplicate radar variant key {variant.radar_key}; keeping the first matching file only"
|
||||
)
|
||||
logger.warning(
|
||||
"Skipping duplicate radar config variant %s (radar_key=%s already seen)",
|
||||
path.name,
|
||||
variant.radar_key,
|
||||
)
|
||||
continue
|
||||
seen_radar_keys.add(variant.radar_key)
|
||||
variants.append(variant)
|
||||
|
||||
logger.info(
|
||||
"Scanned radar config variants in %s: json=%d valid=%d duplicates=%d",
|
||||
directory,
|
||||
len(json_paths),
|
||||
len(variants),
|
||||
duplicate_variant_count,
|
||||
)
|
||||
|
||||
return variants, RadarConfigScanSummary(
|
||||
directory_path=str(directory),
|
||||
json_file_count=len(json_paths),
|
||||
|
||||
Reference in New Issue
Block a user