Rename kamil_adc to rph_radar and fix its data path

python_app/tests/test_run_config_codec.py

@@ -99,6 +99,17 @@ class StrictNumericTypingTest(unittest.TestCase):
 class StructuralTypingTest(unittest.TestCase):
     """A present-but-wrong-shaped section fails loudly instead of being dropped."""
 
+    def test_old_adc_model_is_rejected_without_alias(self) -> None:
+        payload = _valid_payload()
+        payload["radar"]["model"] = "kamil_adc"
+        with self.assertRaisesRegex(ValueError, "rph_radar"):
+            RunConfigModel.from_dict(payload)
+
+    def test_inactive_old_adc_section_from_saved_profiles_is_ignored(self) -> None:
+        payload = _valid_payload()
+        payload["radar"]["kamil_adc"] = {"tty_path": "/tmp/old"}
+        self.assertEqual(RunConfigModel.from_dict(payload).radar.model, payload["radar"]["model"])
+
     def test_root_must_be_an_object(self) -> None:
         for payload in (None, [], 'bad', 42):
             with self.subTest(payload=payload), self.assertRaisesRegex(ValueError, 'root'):
@@ -112,6 +123,19 @@ class StructuralTypingTest(unittest.TestCase):
 
 
 class AcquisitionValidationTest(unittest.TestCase):
+    def test_rph_key_normalizes_active_laser_mode(self) -> None:
+        keys = []
+        for mode in ("variation", " Variation ", "VARIATION"):
+            config = self.config("rph_radar")
+            laser = config.radar.laser_control
+            laser.enabled, laser.mode = True, mode
+            original = config.radar_key()
+            keys.append(original)
+            laser.variation.max_value += 1
+            with self.subTest(mode=mode):
+                self.assertNotEqual(config.radar_key(), original)
+        self.assertEqual(len(set(keys)), 1)
+
     def test_default_combo_expansion_is_bounded_before_allocation(self) -> None:
         payload = _valid_payload()
         payload["switches"]["port1"]["positions"] = 65536
@@ -149,9 +173,31 @@ class AcquisitionValidationTest(unittest.TestCase):
             ring.slot_size_bytes = original
         validate_acquisition_config(config)
 
-    def test_kamil_requires_native_mode(self) -> None:
+    def test_radar_key_separates_switch_matrices(self) -> None:
+        stock, per_point = self.config("librevna_multi"), self.config("librevna_multi")
+        per_point.radar.multi_device.stimulus_switch_positions = 2
+        self.assertTrue(stock.radar_key().endswith("_out1_in1_stim1"))
+        self.assertNotEqual(stock.radar_key(), per_point.radar_key())
+
+    def test_rph_requires_native_mode(self) -> None:
         with self.assertRaisesRegex(ValueError, "native"):
-            validate_acquisition_config(self.config("kamil_adc"))
+            validate_acquisition_config(self.config("rph_radar"))
+
+    def test_adc_phase_band_and_timeouts_fail_preflight(self) -> None:
+        for section, field, value in (
+            ("phase_calibration", "phase1_rad", 0.0),
+            ("phase_calibration", "freq1_hz", 2_046_000_000.0),
+            ("phase_calibration", "phase0_rad", float("nan")),
+            ("band", "stop_hz", 2_100_000_000.0),
+            ("band", "start_hz", -1.0), ("band", "points", 1),
+            ("", "sweep_timeout_s", 0.0), ("", "startup_timeout_s", float("inf")),
+        ):
+            config = self.config("rph_radar")
+            config.radar.driver_mode = "native"
+            adc = config.radar.rph_radar
+            setattr(getattr(adc, section) if section else adc, field, value)
+            with self.subTest(section=section, field=field), self.assertRaises(ValueError):
+                validate_acquisition_config(config)
 
     def test_matrix_validates_physical_switch_instead_of_virtual_axis(self) -> None:
         config = self.config("librevna_multi")