Refactor radar system

python_app/orchestration/config_writer.py

@@ -2,12 +2,10 @@
 
 from __future__ import annotations
 
-from contextlib import suppress
-import json
 import logging
-import os
 from pathlib import Path
 
+from python_app.file_io import atomic_write_json
 from python_app.models.run_config_model import RunConfigModel, parse_combos_from_text
 from python_app.orchestration.preprocess_assets import (
     PREPROCESS_ASSET_KEYS,
@@ -47,32 +45,9 @@ class ConfigWriter:
             asset.bundle_path = str(bundle_path)
 
     def write(self, config: RunConfigModel, output_path: Path) -> Path:
-        """Atomically write the run configuration JSON file.
-
-        Dump to a sibling ``.tmp``, flush + ``fsync`` to durably commit the bytes on
-        the SD-card-backed Pi, then ``os.replace()`` atomically onto the destination.
-        A C++ consumer can therefore never observe a half-written config (which would
-        abort it with an opaque JSON parse error), even across a crash or power loss.
-        """
-        output_path.parent.mkdir(parents=True, exist_ok=True)
-        # allow_nan=False: a stray NaN/Infinity must fail loudly here in Python
-        # rather than serialize to a non-standard token that aborts every C++
-        # consumer at startup with an opaque JSON parse error.
-        serialized = json.dumps(config.to_dict(), indent=2, allow_nan=False)
-        tmp_path = output_path.with_suffix(output_path.suffix + ".tmp")
-        try:
-            with open(tmp_path, "w", encoding="utf-8") as handle:
-                handle.write(serialized)
-                handle.flush()
-                os.fsync(handle.fileno())
-            os.replace(tmp_path, output_path)
-        except Exception:
-            logger.exception("Failed to write run config to %s; removing temp file", output_path)
-            # Never leave a half-written .tmp behind on a write/fsync failure.
-            with suppress(OSError):
-                tmp_path.unlink()
-            raise
-        logger.debug("Wrote run config to %s (%d bytes)", output_path, len(serialized))
+        """Atomically write and sync the run configuration JSON file."""
+        atomic_write_json(output_path, config.to_dict(), durable=True)
+        logger.debug("Wrote run config to %s", output_path)
         return output_path